From 8e001d3f46cd96df3e84e18d960abc88594c913b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20H=C3=A4nisch?= Date: Tue, 20 Aug 2019 23:57:22 +0200 Subject: [PATCH 1/3] fix: default export a function in global script --- src/components/global.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/components/global.ts b/src/components/global.ts index 7d6db1a53..5057f50b6 100644 --- a/src/components/global.ts +++ b/src/components/global.ts @@ -1,3 +1,5 @@ import { setMode } from '@stencil/core'; -setMode((el: any) => el.tagName === 'ION-ICON' ? el.mode || el.getAttribute('mode') : null); +export default () => { + setMode((el: any) => el.tagName === 'ION-ICON' ? el.mode || el.getAttribute('mode') : null); +} From ff5580ed2aacdec24bd9d21dd8858b914021168d Mon Sep 17 00:00:00 2001 From: simonhaenisch Date: Wed, 21 Aug 2019 00:07:58 +0200 Subject: [PATCH 2/3] chore: bump stencil to 1.3.0 --- package.json | 2 +- src/components/global.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 22fb0a14c..ef128291a 100755 --- a/package.json +++ b/package.json @@ -32,7 +32,7 @@ "test": "stencil test --spec" }, "devDependencies": { - "@stencil/core": "1.1.6", + "@stencil/core": "1.3.0", "@stencil/sass": "^1.0.1", "@types/highlight.js": "^9.12.3", "@types/jest": "24.0.13", diff --git a/src/components/global.ts b/src/components/global.ts index 5057f50b6..b20414c1d 100644 --- a/src/components/global.ts +++ b/src/components/global.ts @@ -2,4 +2,4 @@ import { setMode } from '@stencil/core'; export default () => { setMode((el: any) => el.tagName === 'ION-ICON' ? el.mode || el.getAttribute('mode') : null); -} +}; From 4d01a83609ac2836a792716fe9c174d09aecf8a7 Mon Sep 17 00:00:00 2001 From: simonhaenisch Date: Wed, 21 Aug 2019 00:09:36 +0200 Subject: [PATCH 3/3] fix: build script order --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index ef128291a..51822d414 100755 --- a/package.json +++ b/package.json @@ -13,7 +13,7 @@ "collection": "dist/collection/collection-manifest.json", "collection:main": "dist/collection/index.js", "scripts": { - "build": "npm run lint.ts && npm run build.icon && npm run generate && npm run build.css && npm run copy.tasks && npm run test && npm run build.data", + "build": "npm run lint.ts && npm run build.data && npm run build.icon && npm run generate && npm run build.css && npm run copy.tasks && npm run test", "build.css": "node scripts/build-css.js", "build.data": "node scripts/data.js", "build.icon": "stencil build",