Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add window check to icon #735

Closed
wants to merge 1 commit into from
Closed

Add window check to icon #735

wants to merge 1 commit into from

Conversation

xzilja
Copy link

@xzilja xzilja commented Oct 30, 2019

I was playing with ssr and window is undefined was popping up from ionicons. After searching through the repo, I believe this is the only place where it is not guarded.

I was playing with ssr and `window is undefined` was popping up from ionicons. After searching through the repo, I believe this is the only place where it is not guarded.
@wis
Copy link

wis commented Feb 25, 2020

here's the line with the problematic use of window,

const win = window as any;

Edit: just noticed this is a PR that fixes the same issue, maintainers can you triage and probably merge please?

@liamdebeasi liamdebeasi deleted the branch ionic-team:master November 8, 2021 21:26
@liamdebeasi liamdebeasi closed this Nov 8, 2021
@liamdebeasi
Copy link
Member

Hey there!

We recently renamed the primary branch from master to main. Unfortunately, this caused GitHub to automatically close this PR since it was pointed to main.

If you are still interested in having this PR get reviewed please feel free to open a new PR pointing to the main branch. Sorry for any confusion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants