Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/printer mock #1140

Open
wants to merge 2 commits into
base: dev-next
from

Conversation

Projects
None yet
3 participants
@toddhalfpenny
Copy link
Contributor

commented Jan 19, 2016

Added a printer mock and tests (all passing).

@pbernasconi

This comment has been minimized.

Copy link
Collaborator

commented Feb 15, 2016

@toddhalfpenny Thanks for the PR! However we ask that you don't build the ngCordova package for a new PR, because it causes problems for merging other PRs in the future. Would you mind only including the fixes/code that your submitted?

@gortok

This comment has been minimized.

Copy link
Collaborator

commented Apr 1, 2016

@toddhalfpenny COuld you strip the dist/ files from your commit? Feel free to strip, rebase your branch; no need to close and re-open PR.

@toddhalfpenny

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2016

Sure, can do... I had done this as I previously didn't and it caused an issue, but that was many months ago.

@gortok

This comment has been minimized.

Copy link
Collaborator

commented Apr 1, 2016

Yea; it's something I didn't learn until after allowing some PRs in that didn't do that and causing issues for myself.

@gortok

This comment has been minimized.

Copy link
Collaborator

commented Apr 21, 2016

Looks like there are merge conflicts; try again?

@gortok
Copy link
Collaborator

left a comment

Still have conflicts because the demo/*** files were included (don't build when running, just run jscs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.