Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove menu toggles #807

Conversation

Projects
None yet
1 participant
@calendee
Copy link
Contributor

commented Jun 25, 2019

Ensure list items in sidemenu are visible when displaying on desktop above the static breakpoint.

Fixes #806

fix: remove menu toggles
Ensure list items in sidemenu are visible when displaying on desktop above the static breakpoint.

@dwieeb dwieeb requested a review from elylucas Jun 25, 2019

calendee added some commits Jun 29, 2019

@calendee

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2019

My proposed solution actually breaks the functionality of the side menu in mobile views. The IonMenuToggle is used to automatically close the side menu when pressed in mobile view.

In addition, this bug in desktop view is fixed in the latest release of the starter.

@calendee calendee closed this Jul 4, 2019

@calendee calendee deleted the calendee:fix/remove-menu-toggle-around-list-items branch Jul 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.