Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace onclick handlers with links for accessibility #824

Merged
merged 2 commits into from Jul 8, 2019

Conversation

Projects
None yet
2 participants
@calendee
Copy link
Contributor

commented Jul 5, 2019

onClick handlers are functional but they are not accessible. Replace them with Link to create accessible anchor tags.

FYI: I was not able to figure out how to use Link tags with the individual tabs. Wrapping the tabs in Links made them disappear. Wrapping the content of the tabs in Links worked but affected the styling.

Fixes #823

calendee added some commits Jul 5, 2019

fix: replace links with hrefs
Any `ion-item` that has an `href` is rendered with a link in the shadow DOM.  Using a Link tag is not necessary.
@calendee

This comment has been minimized.

Copy link
Contributor Author

commented Jul 6, 2019

UPDATE: The tabs in the tab bar are automatically accessible as they include an href. See: https://calendee.com/2019/07/06/accessibility-in-ionic-framework-apps/

@dwieeb dwieeb requested a review from elylucas Jul 8, 2019

@elylucas elylucas merged commit 587c6ec into ionic-team:master Jul 8, 2019

5 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test_angular Your tests passed on CircleCI!
Details
ci/circleci: test_ionic1 Your tests passed on CircleCI!
Details
ci/circleci: test_ionic_angular Your tests passed on CircleCI!
Details
ci/circleci: test_react Your tests passed on CircleCI!
Details
@elylucas

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Thanks!

@calendee calendee deleted the calendee:fix/use-accessible-links branch Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.