fix(compiler): use transformed css to check changed imports of globalStyle #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change:
When checking for changed CSS imports of the
globalStyle, it now uses the transformation result of the plugins that are applied to theglobalStyle(e. g. stylus or sass).For example, I'm using
@stencil/stylus, and myglobalStyleissrc/global/app.styl. Previously it would readconfig.globalStylefrom the file system, a.stylfile in this case, but treat it as CSS. That could cause an error where a regex would fail that would extract the css import paths (because in stylus it's possible to omit semicolons).