New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use icons from theme in project explorer #491

Merged
merged 4 commits into from Aug 13, 2017

Conversation

Projects
None yet
2 participants
@vbfox
Contributor

vbfox commented Aug 13, 2017

This PR use the icons from the icon theme (When possible, see limitations) in the project explorer pane

2017-08-13 22_30_35- extension development host - assemblyinfo fs markdownf visual studio code

  • Use the icons for .fs & .fsproj extensions if defined but still use the embeded icons if the theme doesn't define a more specific icon
  • Use the icons for folders
  • Handle light/dark icons
  • Reload the icons when the theme change

Limitations

  • When the icon theme change the tree is reloaded (like when the project change) losing what folders are opened or closed.
  • The specific icon for when a folder is expanded isn't used. (I don't know how to do that)
  • Icon themes that use icons in Fonts (like seti-icons) are NOT supported, and there don't seem to be any way to support them.

Sample with a few themes

2017-08-13 22_31_20- extension development host - assemblyinfo fs markdownf visual studio code 2017-08-13 22_27_56- extension development host - assemblyinfo fs markdownf visual studio code 2017-08-13 22_28_23- extension development host - assemblyinfo fs markdownf visual studio code 2017-08-13 22_29_09- extension development host - assemblyinfo fs markdownf visual studio code 2017-08-13 22_30_15- extension development host - assemblyinfo fs markdownf visual studio code 2017-08-13 22_30_35- extension development host - assemblyinfo fs markdownf visual studio code

@Krzysztof-Cieslak

This comment has been minimized.

Show comment
Hide comment
@Krzysztof-Cieslak

Krzysztof-Cieslak Aug 13, 2017

Member

This so terribly hacky that it's scary... I love it! 💯

Member

Krzysztof-Cieslak commented Aug 13, 2017

This so terribly hacky that it's scary... I love it! 💯

@Krzysztof-Cieslak Krzysztof-Cieslak merged commit 2e866c9 into ionide:master Aug 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment