Revert "Resolve join promise after API channel ready"
#190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4d1d436.
adwpc
added a commit
that referenced
this pull request
Apr 20, 2021
* Revert "Resolve `join` promise after API channel ready (#185)" (#190) This reverts commit 4d1d436. * Resolve `join` promise after API channel ready Previously, the (implicit) promise returned by `join` would resolve after establishing the transports, but before the API data channel was attached. This meant there was a small window of time where the API data channel was not ready, and trying to use the subscriber API during that time would fail silently. This change returns a promise that does not resolve until after the API channel is established. * Set Ion connector's `sfu` before join It's possible for some of the callbacks to fire while awaiting `sfu.join`, and those callbacks may need to access the connector's `sfu` property. So we should set it before we start the join. Co-authored-by: adwpc <adwpc@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #185