Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Updates Ionyweb to use z-index greater than 9000 #17

Open
wants to merge 4 commits into
from

Conversation

Projects
None yet
3 participants

Hey,

This should fix issue #14 as per your instructions, I have not had a chance to test this yet.

Cheers,

Chris

chrisfranklin added some commits Mar 1, 2013

Update Z index for iony admin panels so they are on top
Set all Ionyweb z-index values above 9000 so the admin
always displays above the theme if the user follows the
defined standard of not using any index above 9000.
Documents z-index standard for Ionyweb admin panels
Adds documentation warning the user not to set the
value of z-index above 9000 so as not to conflict
with Ionyweb

@Natim Natim commented on an outdated diff Mar 1, 2013

ionyweb/static/admin/css/ionyweb_admin.less
@@ -100,7 +100,7 @@
/* Each UL is a list of action in admin_tool_bar*/
ul.toolbar_menu{
- z-index: 1100;
+ z-index: 9100;
@Natim

Natim Mar 1, 2013

Contributor

900 to 9100,
950 to 9200,
1000 to 9300,
1100 to 9400

It should be 9400 here I think.

Contributor

Natim commented Mar 1, 2013

There is just a little question with line 103 of ionyweb_admin.less and I think we will be good to merge :)

Fix z-index from 9100 to 9400 originally converted from 1100
Corrected the wrong z-index as per these instructions:

900 to 9100,
950 to 9200,
1000 to 9300,
1100 to 9400

@Natim Natim and 1 other commented on an outdated diff Mar 1, 2013

ionyweb/static/admin/css/ionyweb_admin_dark.less
@@ -18,7 +18,7 @@
/* When mouse hover a plugin, background change */
@background_hover: rgba(0, 0, 0, 0.2); /* background of the admin section : also #444 or #999*/
-@zindex: 1000;
+@zindex: 9000;
@Natim

Natim Mar 1, 2013

Contributor

1000 to 9300

@chrisfranklin

chrisfranklin Mar 1, 2013

Some of the classes perform arithmetic on this value, does this matter?

@Natim

Natim Mar 1, 2013

Contributor

Maybe...

@Natim

Natim Mar 1, 2013

Contributor

I checked, it should be ok.

That should be all, thanks for the nice easy one to get me started =) have you guys got a roadmap or a list of features / bugs that you would like people to work on?

@Natim Natim commented on an outdated diff Mar 1, 2013

ionyweb/static/admin/css/ionyweb_login.less
@@ -14,7 +14,7 @@
@background_widget: rgba(220, 220, 220, 0.3); /* background of the admin section : also #444 or #999*/
@background_hover: rgba(220, 220, 220, 0.1); /* background of the admin section : also #444 or #999*/
-@zindex: 1000;
+@zindex: 9000;
@Natim

Natim Mar 1, 2013

Contributor

1000 to 9300

Contributor

Natim commented Mar 1, 2013

I am a bit perfectionist I guess.

Can you also run make less to compile them for production ?

Fix 1000 being set to 9000 when it should be 9300
Fix wrong z-index and recompile less files for production

Sorry for this being quite such a mess, do I need to make any other changes to get this included? I promise to be more precise in future.

almet commented Jul 9, 2014

@Natim ping

@Natim Natim commented on the diff Jul 9, 2014

ionyweb/static/admin/css/$
@@ -0,0 +1,1948 @@
+/* General administration variables */
@Natim

Natim Jul 9, 2014

Contributor

Strange filename.

@Natim Natim commented on the diff Jul 9, 2014

ionyweb/static/admin/css/ionyweb_login.min.css
@@ -1,21 +1,236 @@
-@font-face{font-family:'MarketingScriptRegular';src:url('fonts/MarketingScript-webfont.eot');src:url('fonts/MarketingScript-webfont.eot?#iefix') format('embedded-opentype'),url('fonts/MarketingScript-webfont.woff') format('woff'),url('fonts/MarketingScript-webfont.ttf') format('truetype'),url('fonts/MarketingScript-webfont.svg#MarketingScriptRegular') format('svg');font-weight:normal;font-style:normal;}@font-face{font-family:'PacificoRegular';src:url('fonts/Pacifico-webfont.eot');src:url('fonts/Pacifico-webfont.eot?#iefix') format('embedded-opentype'),url('fonts/Pacifico-webfont.woff') format('woff'),url('fonts/Pacifico-webfont.ttf') format('truetype'),url('fonts/Pacifico-webfont.svg#PacificoRegular') format('svg');font-weight:normal;font-style:normal;}#ionyweb_admin_login{font-family:Verdana;position:fixed;display:none;width:500px;height:300px;top:50%;left:50%;margin-top:-150px;margin-left:-250px;background:-moz-linear-gradient(top, #444444 0%, #222222 100%) !important;background:-webkit-gradient(linear, left top, left bottom, color-stop(0%, #444444), color-stop(100%, #222222)) !important;border-radius:18px !important;-moz-border-radius:18px !important;-webkit-border-radius:18px !important;-moz-box-shadow:0px 0px 10px 2px #000000 !important;-webkit-box-shadow:0px 0px 10px 2px #000000 !important;box-shadow:0px 0px 10px 2px #000000 !important;z-index:99999;}#ionyweb_admin_login div.logo{padding:0;}#ionyweb_admin_login div.logo h2{float:left;margin:0;position:absolute;left:10px;font-family:"PacificoRegular";color:white;text-shadow:#000000 1px 2px 4px;background:-moz-linear-gradient(top, #d5a96a 0%, #ef7746 100%) !important;background:-webkit-gradient(linear, left top, left bottom, color-stop(0%, #d5a96a), color-stop(100%, #ef7746)) !important;padding:0px 20px 0px 20px;margin-left:10px;font-size:3.2em;font-style:normal;-webkit-border-bottom-right-radius:10px;-webkit-border-bottom-left-radius:10px;-moz-border-radius-bottomright:10px;-moz-border-radius-bottomleft:10px;border-bottom-right-radius:10px;border-bottom-left-radius:10px;text-transform:none !important;font-weight:normal !important;}#ionyweb_admin_login div.logo h2 a{color:white;}#ionyweb_admin_login div.logo h2 a:hover{color:white;}
@Natim

Natim Jul 9, 2014

Contributor

not minified anymore?

Contributor

Natim commented Jul 9, 2014

I definitly want to merge that thank you and sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment