generate less shaders when r_sunlightMode is disabled #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inolen
commented
Feb 1, 2014
inolen
commented
- don't generate shaders for LIGHTDEF_USE_SHADOWMAP when r_sunlightMode is disabled (16 less iirc)
- wrap usage of standard derivatives functions in conditional so they can compile when unsupported and disabled
… is disabled wrap usage of standard derivatives functions in conditional so they can compiled when unsupported and disabled
|
Is this still an issue? (that would then require an updated PR) |
|
The changes to the lightall shader aren't relevant any more, the code calculating tangent spaces in the fragment program has been removed. Not compiling in LIGHTDEF_USE_SHADOWMAP code when r_sunlightMode is 0 is still relevant though, but I can write a quick commit for that myself. |
SmileTheory
added a commit
that referenced
this pull request
Jan 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.