Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Language Support and Korean Translation #29

Merged
merged 6 commits into from Jun 11, 2018

Conversation

@pilgwon
Copy link
Contributor

pilgwon commented Jun 7, 2018

  • Translate factor and so on in Korean.
  • Add multi language support (first, english and korean)
@KrauseFx

This comment has been minimized.

Copy link
Member

KrauseFx commented Jun 7, 2018

Deploy preview for ios-factor ready!

Built with commit 3492a7a

https://deploy-preview-29--ios-factor.netlify.com

Copy link
Member

KrauseFx left a comment

This is so beautiful, thank you so much for your time and work on this, excited to add more languages to this soon. Only one small thing, and then it's ready to be merged and shipped 🚀


This project is in no way affiliated with Apple
{{ site.languageNames[site.lang] }}
{% for lang in site.languageNames %}

This comment has been minimized.

Copy link
@KrauseFx

KrauseFx Jun 8, 2018

Member

Do you think we could make this link to the specific page (e.g. a specific factor) when switching the language?

This comment has been minimized.

Copy link
@KrauseFx

KrauseFx Jun 8, 2018

Member

e.g. that it links to

/ko/prefer-local-over-remote

This comment has been minimized.

Copy link
@pilgwon

pilgwon Jun 9, 2018

Author Contributor

added {{ page.url }}. now we can change just language in same factor!

<a href="https://github.com/ios-factor/ios-factor.com/edit/master/{{ page.path }}" target="_blank" class="forkButton">
{% include icon-github.svg %}
Edit on GitHub
</a>

This comment has been minimized.

Copy link
@KrauseFx

KrauseFx Jun 8, 2018

Member

Missing new line

This comment has been minimized.

Copy link
@pilgwon

pilgwon Jun 9, 2018

Author Contributor

added :)

@pilgwon

This comment has been minimized.

Copy link
Contributor Author

pilgwon commented Jun 9, 2018

because of multi language support, #30's factors/dependencies.md file is moved to _i18n/en/factors/dependencies.md.

pilgwon added 3 commits Jun 9, 2018
…tor) when switching the language? (ex. /ko/prefer-local-over-remote -> /prefer-local-over-remote)
@pilgwon

This comment has been minimized.

Copy link
Contributor Author

pilgwon commented Jun 9, 2018

  1. update footer language selector in _includes/footer.html
  2. added missing new line in _i18n/en/fork.html
  3. resolve conflict between #30 (#30's newer dependencies factor moved to _i18n/en/dependencies.md)
@KrauseFx

This comment has been minimized.

Copy link
Member

KrauseFx commented Jun 11, 2018

Thanks for resolving the merge conflicts, this is so great 👍 ❤️

@KrauseFx KrauseFx merged commit 2581651 into ios-factor:master Jun 11, 2018
1 check passed
1 check passed
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.