Skip to content

infinite mode without copying slides #96

Closed
naltatis opened this Issue Aug 30, 2012 · 8 comments

4 participants

@naltatis

Copying slides makes trouble when you are using id's in your slides.

@iosscripts

You're right, I have been giving this some thought lately. Looking for a better approach that might involve moving slides around instead of duplicating slides.

@ColColonCleaner

Suggest using detach() then append()/appendChild()

Detach keeps all bindings intact while you move the item around.

@iosscripts

That would work, sure. I was also thinking about adding position: relative; and left: XXpx to each slide and then changing the left value to move slides around. That would mean that there is no instance in time where the slide is removed from the DOM. But, I'll have to check and see which method would use less processing.

@ColColonCleaner

Well moving the slide with css is probably a better option than removing and adding again, the only problem is that you will run into the case where the slides are in a different order on screen than in slider's list of nodes. It would be good for performance using that approach too, moving divs with css takes a lot less work than appending.

@marcwhitbread marcwhitbread pushed a commit that referenced this issue Sep 4, 2012
Marc Whitbread working through infinite optomization/testing
- ref issue #96
9f8802b
@marcwhitbread marcwhitbread pushed a commit that referenced this issue Sep 5, 2012
Marc Whitbread testing for issue #96 0845860
@marcwhitbread marcwhitbread pushed a commit that referenced this issue Sep 6, 2012
Marc Whitbread working through issue #96.
- Major code changes complete.
- Debugging agains't benchmarks.
- Moving toward v1.1
88cfd7f
@iosscripts iosscripts pushed a commit that referenced this issue Sep 7, 2012
@marcwhitbread marcwhitbread working through issue #96 99afec4
@marcwhitbread marcwhitbread pushed a commit that referenced this issue Sep 7, 2012
Marc Whitbread working through #96 7b5d9a8
@iosscripts iosscripts pushed a commit that referenced this issue Sep 10, 2012
@marcwhitbread marcwhitbread testing issue #96 ea20625
@marcwhitbread marcwhitbread pushed a commit that referenced this issue Sep 10, 2012
Marc Whitbread working #96 call back functions 2ede6e3
@daegloe
daegloe commented Sep 11, 2012

With this change, when infiniteSlider and autoSlide are both true, will it continue to scroll endlessly in the right-to-left direction?

@iosscripts

It will yes. It does do this currently I believe. I am aiming to maintain all current functionality while still making this change.

@daegloe
daegloe commented Sep 11, 2012

Ah yes, you are correct.

@iosscripts iosscripts pushed a commit that referenced this issue Sep 13, 2012
@marcwhitbread marcwhitbread testing issue #96 c4fd058
@marcwhitbread marcwhitbread pushed a commit that referenced this issue Sep 13, 2012
Marc Whitbread working on issue #96 771eb4d
@iosscripts iosscripts pushed a commit that referenced this issue Sep 14, 2012
@marcwhitbread marcwhitbread #96. bugs 4053616
@iosscripts iosscripts pushed a commit that referenced this issue Sep 17, 2012
@marcwhitbread marcwhitbread working on issue #96 7a28daa
@iosscripts iosscripts pushed a commit that referenced this issue Sep 19, 2012
@marcwhitbread marcwhitbread issue #96 work 5b1111b
@marcwhitbread marcwhitbread pushed a commit that referenced this issue Sep 19, 2012
Marc Whitbread issue #96 6d25933
@iosscripts iosscripts pushed a commit that referenced this issue Sep 20, 2012
@marcwhitbread marcwhitbread issue #96 progress 7077c78
@marcwhitbread marcwhitbread pushed a commit that referenced this issue Sep 20, 2012
Marc Whitbread issue #96 a64320a
@iosscripts iosscripts pushed a commit that referenced this issue Sep 21, 2012
@marcwhitbread marcwhitbread issue #96 2046379
@marcwhitbread marcwhitbread pushed a commit that referenced this issue Sep 21, 2012
Marc Whitbread issue #96 work a442f8e
@iosscripts iosscripts pushed a commit that referenced this issue Sep 24, 2012
@marcwhitbread marcwhitbread cleaning up issue #96 code cabdcb9
@marcwhitbread marcwhitbread pushed a commit that referenced this issue Sep 24, 2012
Marc Whitbread final edits to #96 13783c3
@iosscripts iosscripts pushed a commit that referenced this issue Sep 26, 2012
@marcwhitbread marcwhitbread debugging benckmarks for issue #96
- final tweaks I swear
33c78f2
@marcwhitbread marcwhitbread pushed a commit that referenced this issue Sep 26, 2012
Marc Whitbread v1.1.0
- fix for issue #96
f8566c5
@iosscripts

Ok, so I have this working now. Didn't realize I would have to overhaul the entire code base, but this is what I was intending on doing for infinite sliding in the first place. I have gone to v1.1.0 on the master branch and is ready for final testing. Hopefully the bugs are minimal.

Let me know if you run into any issues and I will try to fix them as quickly as possible.

@iosscripts iosscripts closed this Sep 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.