Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/vote rpc #942

Merged
merged 10 commits into from Mar 7, 2019
Merged

Feat/vote rpc #942

merged 10 commits into from Mar 7, 2019

Conversation

ziranliu
Copy link
Contributor

@ziranliu ziranliu commented Mar 7, 2019

No description provided.

ziranliu and others added 3 commits March 7, 2019 14:03
@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #942 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #942      +/-   ##
==========================================
- Coverage   34.73%   34.69%   -0.05%     
==========================================
  Files         100      100              
  Lines        9037     9037              
==========================================
- Hits         3139     3135       -4     
- Misses       5503     5506       +3     
- Partials      395      396       +1
Impacted Files Coverage Δ
db/wal/stream_file.go 95.34% <0%> (-4.66%) ⬇️
ilog/logger.go 62.24% <0%> (-1.03%) ⬇️

rpc/api_service.go Outdated Show resolved Hide resolved
Copy link
Contributor

@lileicool1 lileicool1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@ziranliu ziranliu merged commit bcb7c56 into master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants