Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Storage #28

Open
wants to merge 4 commits into
base: master
from
Open

RFC: Storage #28

wants to merge 4 commits into from

Conversation

@tsvisabo
Copy link
Member

tsvisabo commented Nov 13, 2019

No description provided.

tsvisabo added 2 commits Nov 13, 2019
@zesterer

This comment has been minimized.

Copy link

zesterer commented Nov 13, 2019

At some point, we should have a discussion about pushing this towards being async-compatible.

tsvisabo added 2 commits Nov 13, 2019
@tsvisabo tsvisabo changed the title bee-rfcs: storage - summary + motivation bee-rfcs: Storage Nov 14, 2019

- Having storage as a trait allows for multiple backends implementations
- API for the moment is minimal, but more methods will be added when needed

This comment has been minimized.

Copy link
@wusyong

wusyong Nov 15, 2019

I think one of alternative could be any established ORM among community.

#[derive(Copy, Clone, Debug, Eq, PartialEq, Hash)]
pub struct MilestoneHash(u64);
impl MilestoneHash {
pub fn is_genesis(&self) -> bool {

This comment has been minimized.

Copy link
@wusyong

wusyong Nov 15, 2019

It would be helpful to also add doc comment on what this is used for.

Ok(())
}
fn destroy_connection(connection: DummyConnection) -> Result<(), ConnectionError> {
Ok(())

This comment has been minimized.

Copy link
@zesterer

zesterer Nov 21, 2019

What is the purpose of this method?

fn destroy_connection(connection: Conn) -> Result<(), ConnectionError>;
}
pub trait Storable {

This comment has been minimized.

Copy link
@zesterer

zesterer Nov 21, 2019

The methods in this trait likely need to become async - could we discuss this at some point?

@thibault-martinez thibault-martinez changed the title bee-rfcs: Storage RFC: Storage Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.