From 999bb97d0692ec07c6da6755f77ed8cf7af893c5 Mon Sep 17 00:00:00 2001 From: Jean Ribeiro Date: Mon, 5 Dec 2022 15:30:57 -0300 Subject: [PATCH 1/3] fix: readonly initial value --- packages/shared/components/molecules/SelectorInput.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/shared/components/molecules/SelectorInput.svelte b/packages/shared/components/molecules/SelectorInput.svelte index 47646169a59..67bd362454c 100644 --- a/packages/shared/components/molecules/SelectorInput.svelte +++ b/packages/shared/components/molecules/SelectorInput.svelte @@ -12,7 +12,7 @@ export let options: IOption[] = [] export let selected: IOption = undefined export let maxHeight: string = 'max-h-64' - export let readonly: boolean = false + export let readonly: boolean = null let value: string = selected?.key ?? selected?.value let previousValue: string = value From be637924eb0cf1450b690ad7735850bdcba671e0 Mon Sep 17 00:00:00 2001 From: Tuditi Date: Tue, 6 Dec 2022 09:38:27 +0100 Subject: [PATCH 2/3] fix: set readonly attribute to undefined --- packages/shared/components/inputs/AssetAmountInput.svelte | 2 +- packages/shared/components/inputs/NftInput.svelte | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/shared/components/inputs/AssetAmountInput.svelte b/packages/shared/components/inputs/AssetAmountInput.svelte index cbe9b2f5f60..89765b90c2f 100644 --- a/packages/shared/components/inputs/AssetAmountInput.svelte +++ b/packages/shared/components/inputs/AssetAmountInput.svelte @@ -20,7 +20,7 @@ export let rawAmount: string = undefined export let unit: string = undefined export let containsSlider: boolean = false - export let disableAssetSelection: boolean = false + export let disableAssetSelection: boolean = null let amount: string = rawAmount ? formatTokenAmountDefault(Number(rawAmount), asset?.metadata, unit, false) diff --git a/packages/shared/components/inputs/NftInput.svelte b/packages/shared/components/inputs/NftInput.svelte index d0e4c4ab7ff..49014fdfd0b 100644 --- a/packages/shared/components/inputs/NftInput.svelte +++ b/packages/shared/components/inputs/NftInput.svelte @@ -7,7 +7,7 @@ export let nftId: string = '' export let error: string = '' - export let readonly: boolean = false + export let readonly: boolean = null let inputElement: HTMLInputElement = undefined let modal: Modal = undefined From 4710eb0cfa67bfeac0ba8b3429e3cf302dab89af Mon Sep 17 00:00:00 2001 From: Tuditi Date: Tue, 6 Dec 2022 09:52:01 +0100 Subject: [PATCH 3/3] chore: add comment --- packages/shared/components/molecules/SelectorInput.svelte | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/shared/components/molecules/SelectorInput.svelte b/packages/shared/components/molecules/SelectorInput.svelte index 67bd362454c..ab91c31d2ea 100644 --- a/packages/shared/components/molecules/SelectorInput.svelte +++ b/packages/shared/components/molecules/SelectorInput.svelte @@ -12,6 +12,8 @@ export let options: IOption[] = [] export let selected: IOption = undefined export let maxHeight: string = 'max-h-64' + // HTML checks whether this value is absent to determine whether the field is readonly + // If the attribute is set to false, HTML interprets it as a readonly field. export let readonly: boolean = null let value: string = selected?.key ?? selected?.value