Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes the exception in chart when there is no longer an active profile #819

Merged
merged 1 commit into from Apr 9, 2021

Conversation

obany
Copy link
Contributor

@obany obany commented Apr 9, 2021

Description of change

If you are in account view and you logout an exception is triggered in the chart currency formatting. This is because as the views are torn down the activeProfile is no longer available and so the currency is undefined.

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Test on windows

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@obany obany requested a review from cvarley100 as a code owner April 9, 2021 07:55
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼

@begonaalvarezd begonaalvarezd merged commit 9e8c853 into develop Apr 9, 2021
@begonaalvarezd begonaalvarezd deleted the fix/chart-currency-exception branch April 9, 2021 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants