New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean configuration flags have undefined behavior #930

Open
GalRogozinski opened this Issue Aug 12, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@GalRogozinski
Contributor

GalRogozinski commented Aug 12, 2018

Bug description

This is a follow up on #910.
The following boolean flags that are true by default and have to be set to false like so:
--dns-refresher false
--dns-resolution false

However other flags that are false by default are set to true w.o specifying value, e.g.
--rescan

Expected behavior

Either use a disabling flag:
--disable-dns-refresher

Or enforce passing a value:
--rescan true

Edit:
We need to give a good error message if we go with option num. 2 and if the flag is used without a passing value.

We need to understand what and how we break things and document it properly.

@jakubcech

This comment has been minimized.

Show comment
Hide comment
@jakubcech

jakubcech Sep 6, 2018

Contributor

I'm for enforcing passing a value

Contributor

jakubcech commented Sep 6, 2018

I'm for enforcing passing a value

@jakubcech jakubcech removed the L-Groom label Sep 20, 2018

@jakubcech jakubcech added this to the Nijmegen milestone Sep 24, 2018

@jakubcech

This comment has been minimized.

Show comment
Hide comment
@jakubcech

jakubcech Oct 8, 2018

Contributor

This will break docker. :)

Contributor

jakubcech commented Oct 8, 2018

This will break docker. :)

@jakubcech

This comment has been minimized.

Show comment
Hide comment
@jakubcech

jakubcech Oct 8, 2018

Contributor
Contributor

jakubcech commented Oct 8, 2018

@jakubcech jakubcech modified the milestones: Nijmegen, Hogwart's Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment