New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing a parameter validation for the local snapshot config parameters #1175

Merged
merged 3 commits into from Nov 20, 2018

Conversation

Projects
None yet
2 participants
@hmoog
Copy link
Contributor

hmoog commented Nov 20, 2018

Description

This PR introduces checks for the config parameters related to Local Snapshots. It simply ensures that the functionality can work as intended by forcing the user to provider parameters that are in the expected range.

Type of change

  • Enhancement (a non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@hmoog hmoog requested a review from GalRogozinski Nov 20, 2018

@GalRogozinski GalRogozinski merged commit 2b59f57 into iotaledger:dev-localsnapshots Nov 20, 2018

2 checks passed

buildkite/iri-build-jar-prs Build #189 passed and blocked
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hmoog hmoog deleted the iotadevelopment:merge_configvalidation branch Nov 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment