New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing a dedicated Transaction Requester Background Worker #1178

Merged
merged 4 commits into from Nov 25, 2018

Conversation

Projects
None yet
2 participants
@hmoog
Copy link
Contributor

hmoog commented Nov 21, 2018

Description

This PR introduces a dedicated background worker that tries to work through the request queue by sending random tips along the requested transactions. This massively increases the sync speed of new nodes that would otherwise be limited to requesting in the same rate as new transactions are received.

Note: To reduce the overhead for the node we only trigger this worker if the request queue gets bigger than the "REQUESTER_THREAD_ACTIVATION_THRESHOLD". Otherwise we rely on the processing of the queue due to normal outgoing traffic like transactions that get relayed by our node.

Type of change

  • Enhancement (a non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

@hmoog hmoog requested review from GalRogozinski and alon-e Nov 21, 2018

@GalRogozinski

This comment has been minimized.

Copy link
Member

GalRogozinski commented Nov 25, 2018

The fix to the broadcast test is not on this branch so it still fails on buildkite

@GalRogozinski GalRogozinski merged commit 833b404 into iotaledger:dev-localsnapshots Nov 25, 2018

4 of 6 checks passed

buildkite/iri-build-jar-prs Build #216 failed (11 minutes, 49 seconds)
Details
buildkite/iri-build-jar-prs/87deaea8-61a3-42c1-acac-e6e048c0954d Failed (exit status 1)
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
buildkite/iri-build-jar-prs/build-iri-oracle8 Passed (3 minutes, 17 seconds)
Details
buildkite/iri-build-jar-prs/pull-from-repo Passed (1 minute, 43 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hmoog hmoog deleted the iotadevelopment:merge_txreqthread branch Nov 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment