New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: made boolean parameters receive a value #1224

Merged
merged 1 commit into from Dec 10, 2018

Conversation

Projects
None yet
2 participants
@hmoog
Copy link
Contributor

hmoog commented Dec 7, 2018

Description

This PR changes the boolean flags of local snapshots to accept a value on the command line (true/false).

Before it was only possible to set the value in the config.

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
@GalRogozinski
Copy link
Member

GalRogozinski left a comment

Did you fill in the requirements in #1223 ?

@GalRogozinski
Copy link
Member

GalRogozinski left a comment

Will fill in the requiremnets of #1223 in a different commit

@GalRogozinski GalRogozinski merged commit 4f6c53a into iotaledger:dev-localsnapshots Dec 10, 2018

6 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
buildkite/iri-build-jar-prs Build #272 passed (8 minutes, 36 seconds)
Details
buildkite/iri-build-jar-prs/86774f74-f11b-48a3-856a-a271d0a20fc9 Passed (6 minutes, 32 seconds)
Details
buildkite/iri-build-jar-prs/build-iri-oracle8 Passed (1 minute, 39 seconds)
Details
buildkite/iri-build-jar-prs/pull-from-repo Passed (14 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment