New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Disable snapshot logic completely if disabled in the config #1228

Merged
merged 3 commits into from Dec 11, 2018

Conversation

Projects
None yet
2 participants
@hmoog
Copy link
Contributor

hmoog commented Dec 10, 2018

Description

This PR completely disables the creation of the snapshot related managers and classes if the features are disabled in the config.

Type of change

  • Enhancement (a non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

@hmoog hmoog changed the title Feat: Disable snapshot logic completely if disabled in the confic Feat: Disable snapshot logic completely if disabled in the config Dec 10, 2018

@GalRogozinski GalRogozinski merged commit ffa7a37 into iotaledger:dev-localsnapshots Dec 11, 2018

6 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
buildkite/iri-build-jar-prs Build #277 passed (25 minutes, 8 seconds)
Details
buildkite/iri-build-jar-prs/06d8ed2a-844e-4fdc-9a02-d23419d7f7b3 Passed (6 minutes, 33 seconds)
Details
buildkite/iri-build-jar-prs/build-iri-oracle8 Passed (2 minutes, 19 seconds)
Details
buildkite/iri-build-jar-prs/pull-from-repo Passed (47 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment