New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone status #1264

Merged
merged 13 commits into from Jan 10, 2019

Conversation

Projects
None yet
4 participants
@kwek20
Copy link
Member

kwek20 commented Jan 10, 2019

Description

We need a notion of how far back a node is synced in milestones in order to properly query for transactions on a node.

Fixes #1261

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How Has This Been Tested?

Unit tests
getNodeInfo returns expected information

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
@DyrellC

This comment has been minimized.

Copy link
Contributor

DyrellC commented Jan 10, 2019

Tested, and the api responses are returning updated snapshot index milestone as expected.

@@ -33,6 +33,7 @@ Feature: Test API calls on Machine 1
|latestSolidSubtangleMilestone |
|latestSolidSubtangleMilestoneIndex |
|milestoneStartIndex |
|lastSnapshottedMilestoneIndex |

This comment has been minimized.

@DyrellC

DyrellC Jan 10, 2019

Contributor

It's a little nitpicky but if you could make sure that all the margins line up that would be appreciated.

@GalRogozinski

This comment has been minimized.

Copy link
Member

GalRogozinski commented Jan 10, 2019

image

Spamming getNodeInfo on 4 threads with Jmeter
It seems like performance is slowly degrading than stabilizing.

Seems fine to me

kwek20 added some commits Jan 10, 2019

@GalRogozinski GalRogozinski merged commit 647f34e into iotaledger:dev-localsnapshots Jan 10, 2019

5 checks passed

buildkite/iri-build-jar-prs Build #340 passed (11 minutes, 52 seconds)
Details
buildkite/iri-build-jar-prs/520421c9-90d0-4b63-9ff3-247f66531572 Passed (9 minutes, 5 seconds)
Details
buildkite/iri-build-jar-prs/build-iri-oracle8 Passed (2 minutes, 12 seconds)
Details
buildkite/iri-build-jar-prs/pull-from-repo Passed (28 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment