New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the minimum value for LOCAL_SNAPSHOTS_PRUNING_DELAY #1267

Merged
merged 4 commits into from Jan 10, 2019

Conversation

Projects
None yet
3 participants
@GalRogozinski
Copy link
Member

GalRogozinski commented Jan 10, 2019

Description

Change the minimum value for LOCAL_SNAPSHOTS_PRUNING_DELAY to 10,000

Fixes #1265

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How Has This Been Tested?

Unit tests added to check for failure when we configure value below minimum

Checklist:

Please delete items that are not relevant.

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

GalRogozinski added some commits Jan 10, 2019

@GalRogozinski GalRogozinski requested review from kwek20 and alon-e Jan 10, 2019

Show resolved Hide resolved src/main/java/com/iota/iri/conf/BaseIotaConfig.java Outdated
@@ -265,6 +265,32 @@ public void testInvalidIni() throws IOException {
ConfigFactory.createFromFile(configFile, false);
}


@Test(expected = IllegalArgumentException.class)
public void pruningSnpashotDelayBelowMin() throws IOException {

This comment has been minimized.

@kwek20

kwek20 Jan 10, 2019

Member

pruningSnapshotDelayBelowMin*

}

@Test
public void pruningSnpashotDelayIsMin() throws IOException {

This comment has been minimized.

@kwek20

kwek20 Jan 10, 2019

Member

same typo

GalRogozinski added some commits Jan 10, 2019

@kwek20

kwek20 approved these changes Jan 10, 2019

@jakubcech

This comment has been minimized.

Copy link
Contributor

jakubcech commented Jan 10, 2019

Awesome, thanks!

@GalRogozinski GalRogozinski merged commit 50c9494 into iotaledger:dev-localsnapshots Jan 10, 2019

5 checks passed

buildkite/iri-build-jar-prs Build #332 passed (10 minutes, 29 seconds)
Details
buildkite/iri-build-jar-prs/17c601b1-77ee-4062-b6c3-01498daecb02 Passed (8 minutes, 3 seconds)
Details
buildkite/iri-build-jar-prs/build-iri-oracle8 Passed (1 minute, 58 seconds)
Details
buildkite/iri-build-jar-prs/pull-from-repo Passed (15 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GalRogozinski GalRogozinski added this to the Calembel milestone Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment