Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd configurable variables for spent addresses DB #1274
+47
−23
Conversation
This comment has been minimized.
This comment has been minimized.
Thanks @viossat I want to have a quick talk with the IRI team on my comment, #1268 (comment), before we merge. I just want the process of syncing from local snapshots to be clear |
GalRogozinski
approved these changes
Jan 15, 2019
GalRogozinski
merged commit 390d846
into
iotaledger:dev
Jan 15, 2019
6 checks passed
Codacy/PR Quality Review
Up to standards. A positive pull request.
Details
buildkite/iri-build-jar-prs
Build #342 passed (13 minutes, 38 seconds)
Details
buildkite/iri-build-jar-prs/0bf27a21-5d20-4d8d-b3d0-d4ba03f744cf
Passed (11 minutes, 4 seconds)
Details
buildkite/iri-build-jar-prs/build-iri-oracle8
Passed (2 minutes)
Details
buildkite/iri-build-jar-prs/pull-from-repo
Passed (15 seconds)
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
GalRogozinski
referenced this pull request
Jan 28, 2019
Merged
Fix: test existence of spent addresses db do not point to correct folder #1305
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
viossat commentedJan 12, 2019
•
edited
Description
The
SPENT_ADDRESSES_DB
andSPENT_ADDRESSES_LOG
paths are currently hardcoded. This PR makes them configurable similarly toDB_PATH
andDB_LOG_PATH
.Fix #1268
Type of change
Checklist: