New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable variables for spent addresses DB #1274

Merged
merged 1 commit into from Jan 15, 2019

Conversation

Projects
None yet
2 participants
@viossat
Copy link
Contributor

viossat commented Jan 12, 2019

Description

The SPENT_ADDRESSES_DB and SPENT_ADDRESSES_LOG paths are currently hardcoded. This PR makes them configurable similarly to DB_PATH and DB_LOG_PATH.

Fix #1268

Type of change

  • Enhancement (a non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
@GalRogozinski

This comment has been minimized.

Copy link
Member

GalRogozinski commented Jan 13, 2019

Thanks @viossat

I want to have a quick talk with the IRI team on my comment, #1268 (comment), before we merge.

I just want the process of syncing from local snapshots to be clear

@GalRogozinski GalRogozinski merged commit 390d846 into iotaledger:dev Jan 15, 2019

6 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
buildkite/iri-build-jar-prs Build #342 passed (13 minutes, 38 seconds)
Details
buildkite/iri-build-jar-prs/0bf27a21-5d20-4d8d-b3d0-d4ba03f744cf Passed (11 minutes, 4 seconds)
Details
buildkite/iri-build-jar-prs/build-iri-oracle8 Passed (2 minutes)
Details
buildkite/iri-build-jar-prs/pull-from-repo Passed (15 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment