New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: added a buffer to LSManager #1286

Merged
merged 2 commits into from Jan 30, 2019

Conversation

Projects
None yet
2 participants
@kwek20
Copy link
Member

kwek20 commented Jan 16, 2019

Description

To prevent jumping back and forth in and out of sync, there is now a buffer in between.
Only when the latest milestone and latest snapshot differ more than this number, we fall out of sync

Fixes #1209

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How Has This Been Tested?

Not yet tested, will request a node as soon as possible.
submitting the PR to start possible discussion about the implementation

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

@GalRogozinski GalRogozinski requested a review from hmoog Jan 17, 2019

@kwek20 kwek20 changed the title added a buffer to LSManager Fix: added a buffer to LSManager Jan 29, 2019

@GalRogozinski GalRogozinski merged commit bf40222 into iotaledger:dev Jan 30, 2019

6 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
buildkite/iri-build-jar-prs Build #355 passed (16 minutes, 21 seconds)
Details
buildkite/iri-build-jar-prs/build-iri-oracle8 Passed (2 minutes, 5 seconds)
Details
buildkite/iri-build-jar-prs/d23db44e-cd3f-46e1-9620-e20aa8bb75a9 Passed (13 minutes, 47 seconds)
Details
buildkite/iri-build-jar-prs/pull-from-repo Passed (16 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment