New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for (closed) issue #1086, missing user-agent header in cors #1319

Merged
merged 1 commit into from Feb 4, 2019

Conversation

Projects
None yet
2 participants
@ovanwijk
Copy link
Contributor

ovanwijk commented Feb 1, 2019

Description

Please include a summary of the change. Include the motivation for the change.

Fixes # (issue)

#1086

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How Has This Been Tested?

Made CORS requests and it now works on blink engine browsers (Firefox, safari etc)

Checklist:

Please delete items that are not relevant.

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes
@GalRogozinski

This comment has been minimized.

Copy link
Member

GalRogozinski commented Feb 3, 2019

@jakubcech
We said all non-stabilizing changes should go to 1.6.2
However this is small. If you approve I will merge.

@GalRogozinski GalRogozinski merged commit ca704d9 into iotaledger:dev Feb 4, 2019

6 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
buildkite/iri-build-jar-prs Build #399 passed (9 minutes, 9 seconds)
Details
buildkite/iri-build-jar-prs/6a3961d7-8fe3-49ee-bef4-62f6c423caa1 Passed (5 minutes, 59 seconds)
Details
buildkite/iri-build-jar-prs/build-iri-oracle8 Passed (2 minutes, 29 seconds)
Details
buildkite/iri-build-jar-prs/pull-from-repo Passed (26 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment