Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Gyros - take transaction reattachments into account #1699

Merged
merged 6 commits into from Dec 30, 2019

Conversation

@GalRogozinski
Copy link
Member

GalRogozinski commented Dec 30, 2019

Description

There is an edge case where IRI didn't account for a transaction that was shared between two distinct bundles. Once it marked it as "counted" in one bundle, it was ignored for the next bundle. This lead to a corrupt ledger state.

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How Has This Been Tested?

I ran it on a node that synced from hornet (1) and an isolated node that had a corrupt db (2).

  1. It managed to sync from hornet ✔️
  2. It managed to restore the DB via the "reset corrupted milestone" mechanism

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
kwek20 and others added 4 commits Oct 12, 2019
@GalRogozinski GalRogozinski changed the title Fix: Gyros - take transaction reattachments into account Hotfix: Gyros - take transaction reattachments into account Dec 30, 2019
@GalRogozinski GalRogozinski requested a review from luca-moser Dec 30, 2019
@GalRogozinski GalRogozinski merged commit 1b4cb1f into iotaledger:dev Dec 30, 2019
1 of 3 checks passed
1 of 3 checks passed
buildkite/iri-build-jar-prs/pr Build #427 passed and blocked
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
@GalRogozinski GalRogozinski deleted the GalRogozinski:fix-ledger-calculation branch Dec 30, 2019
GalRogozinski added a commit that referenced this pull request Dec 30, 2019
@GalRogozinski

This comment has been minimized.

Copy link
Member Author

GalRogozinski commented Dec 30, 2019

For clarity, when we have 2 bundle tails R-0 and 0, they both define distinct transfers. Transaction 3 is common to both of them and thus must be accounted twice.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.