New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove checkSolidity mocks #908

Merged
merged 1 commit into from Aug 12, 2018

Conversation

Projects
None yet
2 participants
@GalRogozinski
Contributor

GalRogozinski commented Aug 5, 2018

Description

Due to recent changes, one no no longer has to mock the checkSolidity methods in unit tests.
It is enough to do updateSolidity() on a given transaction.

Fixes #846

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How Has This Been Tested?

All unit tests pass

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes

@GalRogozinski GalRogozinski requested a review from alon-e Aug 5, 2018

@alon-e

alon-e approved these changes Aug 12, 2018

@alon-e alon-e merged commit 7ebad49 into iotaledger:dev Aug 12, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment