Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
some TransactionValidator fixes regarding solidity #913
TipsViewModel is responsible for keeping an accurate picture of the solid and non-solid tips. Currently this view is managed within #TransactionValidator.updateStatus() and a separate TipsSolidifier thread (which is not really efficient since it picks one random non-solid tip at a time each 750ms). This leads to a lag in the tips reality. See also issue #761 and #573. With PR #907 in place, we can manage the TipsViewModel fully within TransactionValidator and keep an accurate and up-to-date picture of the current (solid/non-solid) tips.
my latest 2 commits have minimal (but important) changes:
on a sidenote: i first thought tipssolidifier could be made redundant but now I see the need for this thread (to take care of incidental gaps) so i undid my initial changes there. now the good thing is that my changes to TransactionValidator make sure there are only a few non-solid tips.....this makes sense since most txs become solid in the forward propagation recursion (as defined in TransactionValidator.propagateTransactions)
nice PR! good catch w/ updating the TipsVM on a solid new tx.
referenced this pull request
Aug 12, 2018
One last change and once testing the PR is completed we will merge.
2 more changes, and I think we will be done!