Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Feat: Introducing the GarbageCollector of local snapshots #995
referenced this pull request
Sep 18, 2018
Takes me a long time to review and I still have some stuff to loose ends here I didn't finish looking at.
Before I press the approve button I want you to add unit tests.
One reason I am insisting on it now and not later is because I think your code is not very testable. For instance, if you want to fill in the job queue for a test you must also consolidate...
Anyhows, please write unit tests.
left a comment
Looks a whole lot better!
I was a little annoyed by the cyclic dependency between the TransactionPruner and the Job but it is not so bad.
Still has a few rejects.
Now what is important has been labeled as a bug in the comment. The rest are comments. Some are important, some are nits (like comments I have on the javadocs).