Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use the same byte for entire key #17

Merged
merged 1 commit into from Jul 21, 2018

Conversation

@lutostag
Copy link

lutostag commented Jul 21, 2018

  • this is a flaw that limits the keygen to only 27 possible keys.

Hope this helps!

* this is a flaw that limits the keygen to only 27 possible keys.

Hope this helps!
@l3wi l3wi merged commit 1cdd289 into iotaledger:master Jul 21, 2018
@chrisdukakis

This comment has been minimized.

Copy link
Member

chrisdukakis commented on ea50c24 Jul 22, 2018

Hey @lutostag that's not a flaw; const was block scoped to while and not to keyGen function. New bytes were generated per iteration. Also note that const fits better because we wouldn't need mutation, and it's standard industry practice to use constants over let declarations when possible.

Just posting for clarification, and given it has been merged, please don't waste time to change it back to const, it's still ok.

This comment has been minimized.

Copy link
Member

l3wi replied Jul 22, 2018

I was sitting with @lutostag when he came across this. I wasn't able to reproduce locally but in his env; Node 4.2.6 the behaviour was as described.

I erred on the side of caution and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.