RFC: White Flag #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsvisabo
suggested changes
Mar 8, 2020
thibault-martinez
force-pushed
the
rfc-white-flag
branch
2 times, most recently
from
8a4822a
to
0353e8b
Compare
tsvisabo
suggested changes
Mar 9, 2020
thibault-martinez
force-pushed
the
rfc-white-flag
branch
from
9babfa5
to
db31ed5
Compare
thibault-martinez
force-pushed
the
rfc-white-flag
branch
from
ddb30b4
to
b9ccac3
Compare
samuel-rufi
previously approved these changes
Mar 12, 2020
The RFC describes the change of the white flag very well. The pictures and the pseudo code are relatively easy to follow, advantages and disadvantages are given. The introduction of the white flag concept seems promising and should make the network more performant and stable in times of attacks.
GalRogozinski
reviewed
Mar 22, 2020
GalRogozinski
suggested changes
Mar 22, 2020
Just noticed a point that I think should really change before the RFC is approved
GalRogozinski
suggested changes
Mar 25, 2020
As per Discord discussion we need to define what happens when a milestone approves an invalid bundle.
There should be an error since it should never happen
Alex6323
reviewed
Apr 8, 2020
GalRogozinski
previously approved these changes
Apr 12, 2020
Co-Authored-By: Luca Moser <moser.luca@gmail.com>
luca-moser
approved these changes
Apr 14, 2020
Wollac
approved these changes
Apr 14, 2020
Looks good to me!
Since this is a technical document I would not use contractions. But this should not stop us from merging.
Co-Authored-By: Wolfgang Welz <welzwo@gmail.com>
|
Snapshot signing required for White flag deployment will be a separate RFC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Rendered