Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: White Flag #5

Merged
merged 7 commits into from May 5, 2020
Merged

Conversation

thibault-martinez
Copy link
Member

@thibault-martinez thibault-martinez commented Mar 6, 2020

text/0005-white-flag/0005-white-flag.md Outdated Show resolved Hide resolved
text/0005-white-flag/0005-white-flag.md Outdated Show resolved Hide resolved
text/0005-white-flag/0005-white-flag.md Outdated Show resolved Hide resolved
text/0005-white-flag/0005-white-flag.md Outdated Show resolved Hide resolved
@thibault-martinez thibault-martinez force-pushed the rfc-white-flag branch 2 times, most recently from 8a4822a to 0353e8b Compare Mar 8, 2020
text/0005-white-flag/0005-white-flag.md Outdated Show resolved Hide resolved
text/0005-white-flag/0005-white-flag.md Outdated Show resolved Hide resolved
@thibault-martinez thibault-martinez marked this pull request as ready for review Mar 12, 2020
@thibault-martinez thibault-martinez moved this from Draft to Review in Reviewing process Mar 12, 2020
@samuel-rufi samuel-rufi self-requested a review Mar 12, 2020
samuel-rufi
samuel-rufi previously approved these changes Mar 12, 2020
Copy link
Member

@samuel-rufi samuel-rufi left a comment

The RFC describes the change of the white flag very well. The pictures and the pseudo code are relatively easy to follow, advantages and disadvantages are given. The introduction of the white flag concept seems promising and should make the network more performant and stable in times of attacks.

text/0005-white-flag/0005-white-flag.md Outdated Show resolved Hide resolved
text/0005-white-flag/0005-white-flag.md Outdated Show resolved Hide resolved
text/0005-white-flag/0005-white-flag.md Outdated Show resolved Hide resolved
text/0005-white-flag/0005-white-flag.md Outdated Show resolved Hide resolved
Copy link
Contributor

@GalRogozinski GalRogozinski left a comment

Just noticed a point that I think should really change before the RFC is approved

text/0005-white-flag/0005-white-flag.md Outdated Show resolved Hide resolved
Copy link
Contributor

@GalRogozinski GalRogozinski left a comment

As per Discord discussion we need to define what happens when a milestone approves an invalid bundle.
There should be an error since it should never happen

GalRogozinski
GalRogozinski previously approved these changes Apr 12, 2020
Copy link
Member

@luca-moser luca-moser left a comment

lgtm

text/0005-white-flag/0005-white-flag.md Outdated Show resolved Hide resolved
text/0005-white-flag/0005-white-flag.md Outdated Show resolved Hide resolved
text/0005-white-flag/0005-white-flag.md Outdated Show resolved Hide resolved
@thibault-martinez thibault-martinez requested a review from tsvisabo Apr 13, 2020
Co-Authored-By: Luca Moser <moser.luca@gmail.com>
Wollac
Wollac approved these changes Apr 14, 2020
Copy link
Collaborator

@Wollac Wollac left a comment

Looks good to me!

Since this is a technical document I would not use contractions. But this should not stop us from merging.

text/0005-white-flag/0005-white-flag.md Outdated Show resolved Hide resolved
text/0005-white-flag/0005-white-flag.md Outdated Show resolved Hide resolved
text/0005-white-flag/0005-white-flag.md Outdated Show resolved Hide resolved
text/0005-white-flag/0005-white-flag.md Outdated Show resolved Hide resolved
text/0005-white-flag/0005-white-flag.md Outdated Show resolved Hide resolved
text/0005-white-flag/0005-white-flag.md Outdated Show resolved Hide resolved
text/0005-white-flag/0005-white-flag.md Outdated Show resolved Hide resolved
Co-Authored-By: Wolfgang Welz <welzwo@gmail.com>
@thibault-martinez thibault-martinez requested a review from Alex6323 Apr 15, 2020
@jakubcech jakubcech merged commit d982f3c into iotaledger:master May 5, 2020
@jakubcech
Copy link
Contributor

@jakubcech jakubcech commented May 5, 2020

Snapshot signing required for White flag deployment will be a separate RFC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

8 participants