Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local time for SeedVault export file #1178

Merged
merged 3 commits into from Mar 14, 2019

Conversation

Projects
None yet
2 participants
@laumair
Copy link
Member

commented Mar 13, 2019

Description

Fixes #679

Type of change

  • Enhancement

How Has This Been Tested?

  • Manually tested iOS (debug)

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • For changes to mobile that include native code (including React Native modules): I have verified that both iOS and Android successfully build in both Debug and Release modes
  • For changes to shared: If applicable, I have verified that my changes are implemented correctly in desktop and mobile
@rajivshah3
Copy link
Collaborator

left a comment

Looks good!

Match desktop's seedvault default path
Co-Authored-By: laumair <aquadestructor@icloud.com>

@rajivshah3 rajivshah3 merged commit ba81a06 into iotaledger:develop Mar 14, 2019

10 checks passed

buildkite/trinity-desktop-prs Build #2522 passed (6 minutes, 17 seconds)
Details
buildkite/trinity-mobile-prs Build #2557 passed (8 minutes, 57 seconds)
Details
buildkite/trinity-shared-prs Build #1546 passed (3 minutes, 33 seconds)
Details
ci/bitrise/384139abc249bd17/pr Passed - trinity-desktop
Details
ci/bitrise/e1c71066b5c75521/pr Passed - trinity-mobile
Details
security/snyk - package.json (IOTA Foundation) No manifest changes detected
security/snyk - src/desktop/package.json (IOTA Foundation) No manifest changes detected
security/snyk - src/mobile/android/app/build.gradle (IOTA Foundation) No manifest changes detected
security/snyk - src/mobile/package.json (IOTA Foundation) No manifest changes detected
security/snyk - src/shared/package.json (IOTA Foundation) No manifest changes detected

@laumair laumair deleted the laumair:feat/seedvault-timestamp branch Mar 14, 2019

@cvarley100 cvarley100 referenced this pull request May 7, 2019

Merged

Desktop 0.5.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.