New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Fix issues with dimensions related to Status Bar #980

Merged
merged 7 commits into from Jan 23, 2019

Conversation

Projects
None yet
3 participants
@cvarley100
Copy link
Member

cvarley100 commented Jan 23, 2019

Description

  • Fixes variation in dimensions between Android and iOS

Fixes #911

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How Has This Been Tested?

Tested across iOS and Android

Checklist:

Please delete items that are not relevant.

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes
  • For changes to mobile that include native code (including React Native modules): I have verified that both iOS and Android successfully build in both Debug and Release modes

cvarley100 and others added some commits Jan 18, 2019

Android build fixes (#969)
* Mobile/Android: Use 'bin' version of Gradle

* Mobile/Android: Use build-tools 28.0.3 to suppress warning

* Mobile/Android: Enable aapt2 to suppress warning

* Mobile/Android: Remove drawable-mdpi folder as it will cause errors

When building, these assets are automatically generated. Checking them into this folder will cause errors with duplicate resources

@cvarley100 cvarley100 requested review from laumair and rajivshah3 and removed request for laumair Jan 23, 2019

@cvarley100 cvarley100 merged commit 8e3a102 into develop Jan 23, 2019

9 checks passed

buildkite/trinity-desktop-prs Build #1931 passed (5 minutes, 17 seconds)
Details
buildkite/trinity-mobile-prs Build #1970 passed (10 minutes, 57 seconds)
Details
buildkite/trinity-shared-prs Build #957 passed (1 minute, 57 seconds)
Details
ci/bitrise/e1c71066b5c75521/pr Passed - trinity-mobile
Details
security/snyk - package.json (IOTA Foundation) No new issues
Details
security/snyk - src/desktop/package.json (IOTA Foundation) No new issues
Details
security/snyk - src/mobile/android/app/build.gradle (IOTA Foundation) No manifest changes detected
security/snyk - src/mobile/package.json (IOTA Foundation) No new issues
Details
security/snyk - src/shared/package.json (IOTA Foundation) No new issues
Details

@laumair laumair deleted the bug/dimensions branch Jan 23, 2019

@laumair

This comment has been minimized.

Copy link
Member

laumair commented Jan 23, 2019

Tested on Google Pixel 2 (Genymotion). Works smooth! 👍

This was referenced Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment