Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move multisend tool and add solidity test #1023

Merged
merged 4 commits into from Apr 23, 2019

Conversation

Projects
None yet
2 participants
@Frankonly
Copy link
Contributor

commented Apr 14, 2019

No description provided.

@Frankonly Frankonly requested a review from iotexproject/protocol-team as a code owner Apr 14, 2019

@raullenchai
Copy link
Member

left a comment

We should perhaps have another repo like iotex-syscontracts for contracts like this.

@codecov

This comment has been minimized.

Copy link

commented Apr 15, 2019

Codecov Report

Merging #1023 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1023      +/-   ##
==========================================
+ Coverage   54.32%   54.34%   +0.02%     
==========================================
  Files         159      159              
  Lines       13691    13610      -81     
==========================================
- Hits         7437     7396      -41     
+ Misses       5258     5233      -25     
+ Partials      996      981      -15
Impacted Files Coverage Δ
action/protocol/account/transfer.go 34.56% <0%> (-8.15%) ⬇️
action/protocol/rewarding/fund.go 56.92% <0%> (-4.85%) ⬇️
cli/ioctl/cmd/account/account.go 22.58% <0%> (-1.63%) ⬇️
action/protocol/execution/protocol.go 78.57% <0%> (-1.43%) ⬇️
blockchain/blockchain.go 47.98% <0%> (-1.14%) ⬇️
action/protocol/rewarding/reward.go 74.72% <0%> (-0.75%) ⬇️
action/transfer.go 35.18% <0%> (-0.67%) ⬇️
cli/ioctl/cmd/account/accountdelete.go 0% <0%> (ø) ⬆️
action/depositreward.go 60% <0%> (ø) ⬆️
config/config.go 49.13% <0%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73733a3...a644423. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Apr 15, 2019

Codecov Report

Merging #1023 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1023      +/-   ##
==========================================
+ Coverage   54.23%   54.34%   +0.11%     
==========================================
  Files         159      159              
  Lines       13610    13610              
==========================================
+ Hits         7381     7396      +15     
+ Misses       5243     5233      -10     
+ Partials      986      981       -5
Impacted Files Coverage Δ
consensus/scheme/rolldpos/endorsementmanager.go 79.09% <0%> (+0.9%) ⬆️
consensus/scheme/rolldpos/rolldpos.go 72.22% <0%> (+1.11%) ⬆️
consensus/scheme/rolldpos/rolldposctx.go 64.18% <0%> (+2.2%) ⬆️
consensus/scheme/rolldpos/roundcalculator.go 76.62% <0%> (+2.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 303347e...adb4303. Read the comment docs.

Frankonly added some commits Apr 22, 2019

@Frankonly Frankonly merged commit 8f7700a into iotexproject:master Apr 23, 2019

4 checks passed

GolangCI No issues found!
Details
ci/circleci: build_test_darwin Your tests passed on CircleCI!
Details
ci/circleci: build_test_docker Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@Frankonly Frankonly deleted the Frankonly:multi branch Apr 23, 2019

zjshen14 added a commit to zjshen14/iotex-core that referenced this pull request Apr 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.