Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify ReadContract API #1054

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@lizhefeng
Copy link
Contributor

commented Apr 18, 2019

No description provided.

@lizhefeng lizhefeng requested a review from iotexproject/protocol-team as a code owner Apr 18, 2019

@lizhefeng lizhefeng requested review from dustinxie and CoderZhi Apr 18, 2019

@zjshen14

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2019

@ququzone how urgent/critical is this issue to unblock the antenna?

@codecov

This comment has been minimized.

Copy link

commented Apr 22, 2019

Codecov Report

Merging #1054 into master will decrease coverage by 0.11%.
The diff coverage is 36.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1054      +/-   ##
==========================================
- Coverage   54.43%   54.32%   -0.12%     
==========================================
  Files         159      159              
  Lines       13691    13695       +4     
==========================================
- Hits         7453     7440      -13     
- Misses       5249     5259      +10     
- Partials      989      996       +7
Impacted Files Coverage Δ
tools/executiontester/blockchain/contract.go 0% <0%> (ø) ⬆️
api/api.go 62.98% <57.14%> (+0.07%) ⬆️
consensus/scheme/rolldpos/rolldposctx.go 61.98% <0%> (-4.96%) ⬇️
consensus/scheme/rolldpos/roundcalculator.go 74.02% <0%> (-2.6%) ⬇️
consensus/scheme/rolldpos/rolldpos.go 71.11% <0%> (-1.12%) ⬇️
consensus/scheme/rolldpos/endorsementmanager.go 78.18% <0%> (-0.91%) ⬇️
db/trie/branchnode.go 67.2% <0%> (+1.6%) ⬆️
dispatcher/dispatcher.go 69.23% <0%> (+4.48%) ⬆️
pkg/routine/recurringtask.go 100% <0%> (+7.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cddc8b...0a0d216. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Apr 22, 2019

Codecov Report

Merging #1054 into master will decrease coverage by 0.11%.
The diff coverage is 36.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1054      +/-   ##
==========================================
- Coverage   54.43%   54.32%   -0.12%     
==========================================
  Files         159      159              
  Lines       13691    13695       +4     
==========================================
- Hits         7453     7440      -13     
- Misses       5249     5259      +10     
- Partials      989      996       +7
Impacted Files Coverage Δ
tools/executiontester/blockchain/contract.go 0% <0%> (ø) ⬆️
api/api.go 62.98% <57.14%> (+0.07%) ⬆️
consensus/scheme/rolldpos/rolldposctx.go 61.98% <0%> (-4.96%) ⬇️
consensus/scheme/rolldpos/roundcalculator.go 74.02% <0%> (-2.6%) ⬇️
consensus/scheme/rolldpos/rolldpos.go 71.11% <0%> (-1.12%) ⬇️
consensus/scheme/rolldpos/endorsementmanager.go 78.18% <0%> (-0.91%) ⬇️
db/trie/branchnode.go 67.2% <0%> (+1.6%) ⬆️
dispatcher/dispatcher.go 69.23% <0%> (+4.48%) ⬆️
pkg/routine/recurringtask.go 100% <0%> (+7.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cddc8b...0a0d216. Read the comment docs.

@ququzone

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

@ququzone how urgent/critical is this issue to unblock the antenna?

not urgent, We can set gas manual.

@zjshen14

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

@ququzone can you check if the change here makes sense to antena integration?

@ququzone

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

@ququzone can you check if the change here makes sense to antena integration?

how can I get executed normal method result by this way?

@zjshen14

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

Return data structure will be the same, but the request Paramus become execution plus caller addr @lizhefeng

@lizhefeng lizhefeng closed this May 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.