Skip to content

Add a memorial transfer into the first block #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zjshen14 merged 3 commits into from
Apr 21, 2019
Merged

Add a memorial transfer into the first block #1065

zjshen14 merged 3 commits into from
Apr 21, 2019

Conversation

@zjshen14
Copy link
Contributor

@zjshen14 zjshen14 commented Apr 21, 2019

No description provided.

@zjshen14 zjshen14 requested a review from raullenchai April 21, 2019 00:13
@zjshen14 zjshen14 requested a review from a team as a code owner April 21, 2019 00:13
golangcibot
golangcibot reviewed Apr 21, 2019
View reviewed changes
blockchain/blockchain.go
}

if raCtx.BlockHeight == 1 {
tsf, err := bc.createMemorialTransfer(raCtx.Producer.String(), raCtx.ActionGasLimit)
Copy link

@golangcibot golangcibot Apr 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ineffectual assignment to err (from ineffassign)

@codecov
Copy link

codecov bot commented Apr 21, 2019

Codecov Report

Merging #1065 into master will increase coverage by 0.06%.
The diff coverage is 85.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1065      +/-   ##
==========================================
+ Coverage    54.3%   54.37%   +0.06%     
==========================================
  Files         159      159              
  Lines       13655    13682      +27     
==========================================
+ Hits         7416     7439      +23     
- Misses       5246     5248       +2     
- Partials      993      995       +2
Impacted Files Coverage Δ
blockchain/blockchain.go 49.24% <85.18%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca20798...80c29f1. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Apr 21, 2019

Codecov Report

Merging #1065 into master will increase coverage by 0.06%.
The diff coverage is 85.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1065      +/-   ##
==========================================
+ Coverage    54.3%   54.37%   +0.06%     
==========================================
  Files         159      159              
  Lines       13655    13682      +27     
==========================================
+ Hits         7416     7439      +23     
- Misses       5246     5248       +2     
- Partials      993      995       +2
Impacted Files Coverage Δ
blockchain/blockchain.go 49.24% <85.18%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca20798...80c29f1. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 21, 2019

Codecov Report

Merging #1065 into master will increase coverage by 0.06%.
The diff coverage is 85.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1065      +/-   ##
==========================================
+ Coverage    54.3%   54.37%   +0.06%     
==========================================
  Files         159      159              
  Lines       13655    13682      +27     
==========================================
+ Hits         7416     7439      +23     
- Misses       5246     5248       +2     
- Partials      993      995       +2
Impacted Files Coverage Δ
blockchain/blockchain.go 49.24% <85.18%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca20798...80c29f1. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 21, 2019 •
edited
Loading

Codecov Report

Merging #1065 into master will increase coverage by 0.03%.
The diff coverage is 79.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1065      +/-   ##
==========================================
+ Coverage    54.3%   54.34%   +0.03%     
==========================================
  Files         159      159              
  Lines       13655    13684      +29     
==========================================
+ Hits         7416     7437      +21     
- Misses       5246     5251       +5     
- Partials      993      996       +3
Impacted Files Coverage Δ
blockchain/blockchain.go 49.12% <79.31%> (+1.13%) ⬆️
db/trie/branchnode.go 65.59% <0%> (-1.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca20798...fc29c53. Read the comment docs.

golangcibot
golangcibot reviewed Apr 21, 2019
View reviewed changes
blockchain/blockchain.go
0,
big.NewInt(0),
recipient,
[]byte("rcqgjsxfdxzszztpydzlzclplz://U2FsdGVkX19E4w2QggPJ/6N38eCU4YTvONyK8A5jZ1XIoQDC2lZBHGe9dDFkN6ToJqaAxcPx6JEzOv/yiVAl6a+Pym+I02BvleW2mcKuMV6tWHRHTnJuu981x2XP2oW9"),
Copy link

@golangcibot golangcibot Apr 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line is 170 characters (from lll)

@zjshen14 zjshen14 merged commit fd846ab into iotexproject:master Apr 21, 2019
zjshen14 added a commit that referenced this pull request Apr 21, 2019
@zjshen14
Add a memorial transfer into the first block (#1065)
a4308fc
zjshen14 added a commit to zjshen14/iotex-core that referenced this pull request Apr 23, 2019
@zjshen14
Revert "Add a memorial transfer into the first block (iotexproject#1065…
3de3754 
…)"

This reverts commit fd846ab.
zjshen14 added a commit that referenced this pull request Apr 24, 2019
@zjshen14
Revert "Add a memorial transfer into the first block (#1065)" (#1078)
e300a1b 
This reverts commit fd846ab.
zjshen14 added a commit to zjshen14/iotex-core that referenced this pull request Apr 26, 2019
@zjshen14
Revert "Add a memorial transfer into the first block (iotexproject#1065…
de296f8 
…)" (iotexproject#1078)

This reverts commit fd846ab.
zjshen14 added a commit that referenced this pull request Apr 26, 2019
@zjshen14
Revert "Add a memorial transfer into the first block (#1065)" (#1078)
fbd71e3 
This reverts commit fd846ab.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raullenchai raullenchai raullenchai approved these changes

+1 more reviewer

@golangcibot golangcibot golangcibot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zjshen14 @raullenchai @golangcibot