Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce two layer trie for factory #1881

Merged
merged 3 commits into from Feb 20, 2020
Merged

Introduce two layer trie for factory #1881

merged 3 commits into from Feb 20, 2020

Conversation

CoderZhi
Copy link
Collaborator

Based on #1880. Introduce two layer trie:
The first layer stores the roots of different namespaces
The second layer stores the values of a namespace

@CoderZhi CoderZhi requested a review from a team as a code owner February 12, 2020 19:23
@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #1881 into master will decrease coverage by 1.6%.
The diff coverage is 33.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1881      +/-   ##
==========================================
- Coverage   61.51%   59.91%   -1.61%     
==========================================
  Files         165      173       +8     
  Lines       13551    14215     +664     
==========================================
+ Hits         8336     8517     +181     
- Misses       4155     4606     +451     
- Partials     1060     1092      +32
Impacted Files Coverage Δ
action/protocol/vote/blacklist.go 92% <ø> (ø) ⬆️
action/protocol/staking/bucket_index.go 85.36% <ø> (ø) ⬆️
consensus/scheme/rolldpos/rolldposctx.go 69.97% <ø> (-3.79%) ⬇️
action/stake_adddeposit.go 0% <0%> (ø)
action/protocol/poll/protocol.go 23.43% <0%> (-1.16%) ⬇️
action/depositreward.go 63.63% <0%> (+3.63%) ⬆️
action/stake_restake.go 0% <0%> (ø)
action/protocol/staking/protocol.go 0% <0%> (ø) ⬆️
action/stake_create.go 0% <0%> (ø)
action/claimreward.go 63.63% <0%> (+3.63%) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 665ce12...2c3375d. Read the comment docs.

@CoderZhi CoderZhi changed the title Namespace trie 2 Introduce two layer trie for factory Feb 12, 2020
@CoderZhi CoderZhi merged commit 6dd23c3 into master Feb 20, 2020
@CoderZhi CoderZhi deleted the namespace_trie_2 branch February 20, 2020 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants