Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent double counting from same endorser #297

Merged
merged 1 commit into from Nov 7, 2018

Conversation

CoderZhi
Copy link
Collaborator

@CoderZhi CoderZhi commented Nov 7, 2018

different consensus vote topics from the same user were counted twice

@CoderZhi CoderZhi requested a review from a team as a code owner November 7, 2018 23:10
@codecov
Copy link

codecov bot commented Nov 7, 2018

Codecov Report

Merging #297 into master will increase coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #297      +/-   ##
==========================================
+ Coverage   64.49%   64.71%   +0.21%     
==========================================
  Files         114      114              
  Lines       10720    10721       +1     
==========================================
+ Hits         6914     6938      +24     
+ Misses       2906     2884      -22     
+ Partials      900      899       -1
Impacted Files Coverage Δ
endorsement/endorsementset.go 54.38% <100%> (+25.81%) ⬆️
network/pinger.go 50% <0%> (+37.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4c1d6d...ea8b218. Read the comment docs.

@CoderZhi CoderZhi merged commit b2bda59 into iotexproject:master Nov 7, 2018
@CoderZhi CoderZhi deleted the endorsement_set branch November 7, 2018 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants