remove programatic mute/unmute discard, don't error if no active call #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the mute/unmute, remove the programatic mute/unmute bypass and rely solely on the
isMutedStateto filter on the plugin side.Don't error if trying to mute/unmute without an active call
I have left in the
isMutedStatein the plugin as we still need a filter on the plugin side. Just one filter on Facetalk wasn't enough to stop an infinite loop. Probably due to how there's two callbacks for every action, so if toggling the mute state between the two duplicate actions then it'll endlessly toggle mute/unnmute.