Skip to content

don't clear callData on the first answer callback #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025
Merged

don't clear callData on the first answer callback #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07ddb6d
don't clear callData on the first answer callback
rex-iotum Apr 11, 2025
8ee579f
bump version
rex-iotum Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "cordova-plugin-callkit",
"version": "1.1.2",
"version": "1.1.3",
"description": "Cordova plugin that lets you use iOS CallKit UI (with PushKit) and Android ConnectionService UI",
"cordova": {
"id": "cordova-plugin-callkit",
Expand Down
2 changes: 1 addition & 1 deletion plugin.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version='1.0' encoding='utf-8'?>
<plugin id="cordova-plugin-callkit" version="1.1.2" xmlns="http://apache.org/cordova/ns/plugins/1.0" xmlns:android="http://schemas.android.com/apk/res/android">
<plugin id="cordova-plugin-callkit" version="1.1.3" xmlns="http://apache.org/cordova/ns/plugins/1.0" xmlns:android="http://schemas.android.com/apk/res/android">
<name>Cordova CallKit</name>

<js-module name="VoIPPushNotification" src="www/VoIPPushNotification.js">
Expand Down
2 changes: 1 addition & 1 deletion src/ios/CordovaCall.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,13 +610,13 @@ - (void)triggerCordovaEventForCallResponse:(NSString*) response {
CDVPluginResult* pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_OK messageAsDictionary:callData];
[pluginResult setKeepCallbackAsBool:YES];
[self.commandDelegate sendPluginResult:pluginResult callbackId:callbackId];
callData = nil; // clear out the data in case CordovaCall.receiveCall('caller'); called from JS side

// CDVPluginResult* pluginResult = nil;
// pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_OK messageAsString:@"answer event called successfully"];
// [pluginResult setKeepCallbackAsBool:YES];
// [self.commandDelegate sendPluginResult:pluginResult callbackId:callbackId];
}
callData = nil; // clear out the data in case CordovaCall.receiveCall('caller'); called from JS side
} else if ([response isEqualToString:@"reject"]) {
for (id callbackId in callbackIds[@"reject"]) {
CDVPluginResult* pluginResult = nil;
Expand Down