New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused ts field in val_t in opensnoop.py. #1981

Merged
merged 1 commit into from Sep 21, 2018

Conversation

Projects
None yet
4 participants
@bolinfest
Contributor

bolinfest commented Sep 21, 2018

Note this allows us to eliminate the bpf_ktime_get_ns()
call from trace_entry().

Remove unused ts field in val_t in opensnoop.py.
Note this allows us to eliminate the `bpf_ktime_get_ns()`
call from `trace_entry()`.

@bolinfest bolinfest requested review from brendangregg and goldshtn as code owners Sep 21, 2018

@bolinfest

This comment has been minimized.

Show comment
Hide comment
@bolinfest

bolinfest Sep 21, 2018

Contributor

While I'm here, why is data.ts = tsp / 1000; done inside trace_return() and then the division by 1000000 done inside print_event()? That is, why not just divide by 1e9 inside print_event()? Is it an issue that the Python cannot represent numbers that large so we have to divide by 1000 while we have it as a u64 in C?

Contributor

bolinfest commented Sep 21, 2018

While I'm here, why is data.ts = tsp / 1000; done inside trace_return() and then the division by 1000000 done inside print_event()? That is, why not just divide by 1e9 inside print_event()? Is it an issue that the Python cannot represent numbers that large so we have to divide by 1000 while we have it as a u64 in C?

@mcaleavya

This comment has been minimized.

Show comment
Hide comment
@mcaleavya

mcaleavya Sep 21, 2018

Contributor
Contributor

mcaleavya commented Sep 21, 2018

@palmtenor

This comment has been minimized.

Show comment
Hide comment
@palmtenor

palmtenor Sep 21, 2018

Member

[buildbot, test this please]

Member

palmtenor commented Sep 21, 2018

[buildbot, test this please]

@yonghong-song yonghong-song merged commit 89aefcc into iovisor:master Sep 21, 2018

1 check passed

default
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment