Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upexpose buitin byte swap methods #453
Conversation
This comment has been minimized.
This comment has been minimized.
|
I think that's a good thing to do regardless of other discussion around ntoa. The macro is kernel specific and clang won't be advertising then. @drzaeus77 could you re-trigger bots? |
drzaeus77
merged commit 7963166
into
iovisor:master
Mar 28, 2016
yadutaf
deleted the
yadutaf:jt-endian
branch
Mar 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
yadutaf commentedMar 28, 2016
This PR makes it possible to directly use byte swap macro from the kernel headers by advertising the compiler's builtin byte swap method. In this commit, this is simply a forced
CFLAGSin the python lib.Not sure this is the best way to do. It should probably go in the clang frontend. Especially if we want to use it from non python programs.