Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose buitin byte swap methods #453

Merged
merged 1 commit into from Mar 28, 2016
Merged

expose buitin byte swap methods #453

merged 1 commit into from Mar 28, 2016

Conversation

@yadutaf
Copy link
Contributor

@yadutaf yadutaf commented Mar 28, 2016

This PR makes it possible to directly use byte swap macro from the kernel headers by advertising the compiler's builtin byte swap method. In this commit, this is simply a forced CFLAGS in the python lib.

Not sure this is the best way to do. It should probably go in the clang frontend. Especially if we want to use it from non python programs.

@4ast
Copy link
Member

@4ast 4ast commented Mar 28, 2016

I think that's a good thing to do regardless of other discussion around ntoa. The macro is kernel specific and clang won't be advertising then. @drzaeus77 could you re-trigger bots?

@drzaeus77 drzaeus77 merged commit 7963166 into iovisor:master Mar 28, 2016
2 checks passed
2 checks passed
buildbot/runtests-fedora Build done.
Details
buildbot/runtests-ubuntu Build done.
Details
@yadutaf yadutaf deleted the yadutaf:jt-endian branch Mar 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants