New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build warnings are turned off #316
Labels
good first issue
Good for newcomers
Comments
Sounds good to me. |
Closed
@danobi Can I take this up? Added PR. |
caringi
added a commit
to caringi/bpftrace
that referenced
this issue
Feb 6, 2019
brendangregg
added a commit
that referenced
this issue
Feb 6, 2019
Re-enable subset of build warnings and fix some related warnings #316
caringi
added a commit
to caringi/bpftrace
that referenced
this issue
Feb 7, 2019
- Re-enabled build warnings -Wall, -Wcast-qual and -Wswitch-default - Fixed all related warnings
brendangregg
added a commit
that referenced
this issue
Feb 11, 2019
Re-enable more build warnings, fix related warnings #316
Looks fixed with #403 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While doing some packaging, I discovered the cmake build has all the build warnings turned off: https://github.com/iovisor/bpftrace/blob/master/CMakeLists.txt#L8-L21 . Any reason for this? Can I turn them back on?
It catches a couple of harmless issues right now. However, we might get lucky in the future and have it catch some trickier bugs.
The text was updated successfully, but these errors were encountered: