Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build warnings are turned off #316

Closed
danobi opened this issue Jan 3, 2019 · 3 comments
Closed

Build warnings are turned off #316

danobi opened this issue Jan 3, 2019 · 3 comments
Labels
good first issue Good for newcomers

Comments

@danobi
Copy link
Member

danobi commented Jan 3, 2019 •
edited

While doing some packaging, I discovered the cmake build has all the build warnings turned off: https://github.com/iovisor/bpftrace/blob/master/CMakeLists.txt#L8-L21 . Any reason for this? Can I turn them back on?

It catches a couple of harmless issues right now. However, we might get lucky in the future and have it catch some trickier bugs.
@danobi danobi changed the title Turn on build warnings Build warnings are turned off Jan 3, 2019
@mmarchini
Copy link
Contributor

Sounds good to me.

@mmarchini mmarchini added the good first issue Good for newcomers label Jan 4, 2019
@sourabhtk37 sourabhtk37 mentioned this issue Feb 5, 2019
Closed
@sourabhtk37
Copy link
Contributor

@danobi Can I take this up? Added PR.

caringi added a commit to caringi/bpftrace that referenced this issue Feb 6, 2019
@caringi
Re-enable subset of build warnings and fix some related warnings bpft…
f0f56b0 
…race#316
brendangregg added a commit that referenced this issue Feb 6, 2019
@brendangregg
Merge pull request #396 from caringi/fix_warnings_1
90e5443 
Re-enable subset of build warnings and fix some related warnings #316
caringi added a commit to caringi/bpftrace that referenced this issue Feb 7, 2019
@caringi
Re-enable more build warnings, fix related warnings bpftrace#316
8c383dc 
- Re-enabled build warnings -Wall, -Wcast-qual and -Wswitch-default
- Fixed all related warnings
brendangregg added a commit that referenced this issue Feb 11, 2019
@brendangregg
Merge pull request #403 from caringi/fix_warnings_2
719e115 
Re-enable more build warnings, fix related warnings #316
@fbs
Copy link
Contributor

fbs commented Dec 17, 2019

Looks fixed with #403

@fbs fbs closed this as completed Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fbs @danobi @mmarchini @sourabhtk37