New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong package name in build instructions #335

Merged
merged 1 commit into from Jan 15, 2019

Conversation

Projects
None yet
5 participants
@danobi
Copy link
Member

danobi commented Jan 11, 2019

No description provided.

@bobrik

bobrik approved these changes Jan 11, 2019

@brendangregg

This comment has been minimized.

Copy link
Member

brendangregg commented Jan 11, 2019

It's now called libbpfcc ! I don't know why it was renamed.

It's still called libbcc in some environments.

Can you add a fix for the cmake error message too for this? It should say you need to install either libbpfcc or libbcc (old package name).

@danobi

This comment has been minimized.

Copy link
Member Author

danobi commented Jan 11, 2019

Can you add a fix for the cmake error message too for this? It should say you need to install either libbpfcc or libbcc (old package name).

Do you think it'd make sense to keep it generic in the error message? For example, I use fedora (requirement at work) and the bcc package is called bcc-devel.

@danobi danobi force-pushed the danobi:ubuntu_install_fix branch from d70bae9 to abf6cdb Jan 11, 2019

@brendangregg

This comment has been minimized.

Copy link
Member

brendangregg commented Jan 11, 2019

I'd make the error message have some human readable text that's generic, followed by package names as examples. Eg:

"Please install the bcc library package, which is required. Depending on your distro, it may be called bpfcclib or bcclib (Ubuntu), bcc-devel (Fedora), or something else. If unavailable, install bcc from source (github.com/iovisor/bcc)."

xbe added a commit to xbe/bpftrace-1 that referenced this pull request Jan 12, 2019

Fix wrong package name in Ubuntu Dockerfile
This corresponds to the change in the install instructions for Ubuntu outlined in iovisor#335.

xbe added a commit to xbe/bpftrace-1 that referenced this pull request Jan 12, 2019

Fix wrong package name in Ubuntu Dockerfile
This corresponds to the change in the install instructions for Ubuntu
outlined in iovisor#335.
@jgallag88

This comment has been minimized.

Copy link

jgallag88 commented Jan 13, 2019

Building on Ubuntu (18.04 and 18.10) is still failing for me, even with these updated instructions. I can install libbpfcc-dev, but compilation fails with

In file included from /home/ubuntu/bpftrace/src/ast/codegen_llvm.h:8:0,
                 from /home/ubuntu/bpftrace/src/ast/codegen_llvm.cpp:2:
/home/ubuntu/bpftrace/src/ast/irbuilderbpf.h:5:10: fatal error: bcc_usdt.h: No such file or directory
 #include "bcc_usdt.h"
          ^~~~~~~~~~~~
compilation terminated.
src/ast/CMakeFiles/ast.dir/build.make:86: recipe for target 'src/ast/CMakeFiles/ast.dir/codegen_llvm.cpp.o' failed
make[2]: *** [src/ast/CMakeFiles/ast.dir/codegen_llvm.cpp.o] Error 1
CMakeFiles/Makefile2:178: recipe for target 'src/ast/CMakeFiles/ast.dir/all' failed
make[1]: *** [src/ast/CMakeFiles/ast.dir/all] Error 2
Makefile:140: recipe for target 'all' failed
make: *** [all] Error 2

If I install bcc from source, bpftrace builds and runs correctly.

@mmarchini

This comment has been minimized.

Copy link
Member

mmarchini commented Jan 14, 2019

Installing libbcc from IO Visor apt repository also works. I think we should recommend that for now on INSTALL.md (similar to what we do for LLVM).

Instructions:

https://github.com/iovisor/bcc/blob/master/INSTALL.md#ubuntu---binary

@danobi danobi force-pushed the danobi:ubuntu_install_fix branch from abf6cdb to baeb5f9 Jan 15, 2019

@danobi

This comment has been minimized.

Copy link
Member Author

danobi commented Jan 15, 2019

@jgallag88 It seems the ubuntu package is missing bcc_usdt.h: https://packages.ubuntu.com/bionic/all/libbpfcc-dev/filelist . Not sure why that is. Upstream debian (sid) has it: https://packages.debian.org/buster/all/libbpfcc-dev/filelist

@brendangregg

This comment has been minimized.

Copy link
Member

brendangregg commented Jan 15, 2019

This rings a bell -- I added bcc_usdt.h in July 2018

iovisor/bcc@5148fce

is that ubuntu package an older bcc version?

@danobi danobi force-pushed the danobi:ubuntu_install_fix branch from baeb5f9 to 8e597de Jan 15, 2019

@danobi

This comment has been minimized.

Copy link
Member Author

danobi commented Jan 15, 2019

According to the package page, Ubuntu 18.04 is on bcc 0.5.0-5, which was tagged Nov 2017

@danobi

This comment has been minimized.

Copy link
Member Author

danobi commented Jan 15, 2019

I've gone ahead and updated the instructions with the known issues in this PR. Are we good to merge now?

danobi added a commit that referenced this pull request Jan 15, 2019

Fix wrong package name in Ubuntu Dockerfile
This corresponds to the change in the install instructions for Ubuntu
outlined in #335.
@brendangregg

This comment has been minimized.

Copy link
Member

brendangregg commented Jan 15, 2019

Thanks!

@brendangregg brendangregg merged commit 8ddfe22 into iovisor:master Jan 15, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@jvnn jvnn referenced this pull request Feb 6, 2019

Closed

Build broken with latest bcc #377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment