Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Build ubuntu image and use them instead of alpine #52

Open
wants to merge 9 commits into
base: master
from

Conversation

@dalehamel
Copy link
Contributor

commented Jan 28, 2019

Fix for #51 and also bumps bpftrace to 0.9.2 from ubuntu eaon

I was able to confirm that the script that doesn't work with static bpftrace works with the dynamically linked one. This is at the expense of a slightly larger (well, 3x larger), though the size here shouldn't matter too much.

As I state in #51, the preferred solution would be to fix the static alpine build (no idea how to do this), or get a static build for ubuntu working (should be possible, others are working on it).

This could at least be a stop-gap until there's a working/non-crashy static image available

@dalehamel dalehamel changed the title WIP ubuntu image build fix: WIP ubuntu image build Jan 28, 2019

@dalehamel dalehamel force-pushed the dalehamel:ubuntu-images branch from a62df10 to 4687eef Mar 24, 2019

@dalehamel dalehamel changed the title fix: WIP ubuntu image build fix: Build ubuntu images and use them by default Mar 24, 2019

@dalehamel

This comment has been minimized.

Copy link
Contributor Author

commented Mar 24, 2019

Looks like I broke CI with this ,will need to see what's up later (train wifi is garbage).

Testing this out locally and seems to work. My approach was to leave the alpine build, and use dependencies to target which build should actually be done in the makefile. This should allow for keeping the alpine image up to date easily.

I moved all the dockerfiles to the build directory as well.

@@ -8,5 +8,6 @@ if [[ ! -z "$TRAVIS_PULL_REQUEST_BRANCH" ]]; then
makeopts="-e GIT_BRANCH=$TRAVIS_PULL_REQUEST_BRANCH"
fi

$make $makeopts bpftraceimage/build # HACK since the ubuntu image isn't pushed yet

This comment has been minimized.

Copy link
@dalehamel

dalehamel Mar 24, 2019

Author Contributor

It seems this was necessary to get the CI to have the tag locally in its cache, since there is nothing for it to pull.

This comment has been minimized.

Copy link
@fntlnz

fntlnz Apr 1, 2019

Member

Just pushed quay.io/iovisor/kubectl-trace-bpftrace-base-ubuntu:49ff42b4e311794cddad24a848b3c225a1b61804" you can remove this now

@dalehamel

This comment has been minimized.

Copy link
Contributor Author

commented Mar 24, 2019

The commit history is ugly, i'll rebase before merging if the changes are approved.

@fntlnz fntlnz requested review from leodido and fntlnz and removed request for leodido Mar 24, 2019

@dalehamel dalehamel changed the title fix: Build ubuntu images and use them by default fix: Build ubuntu image and use them instead of alpine Aug 16, 2019

@dalehamel dalehamel force-pushed the dalehamel:ubuntu-images branch from 230341d to 4438f2e Aug 16, 2019

@dalehamel dalehamel force-pushed the dalehamel:ubuntu-images branch from 4438f2e to 7434747 Aug 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.