Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates from latest release #23

Merged
merged 5 commits into from Jul 14, 2016

Conversation

Projects
None yet
2 participants
@fmessmer
Copy link
Member

commented Apr 1, 2016

chromium-browser is not in the rosdep.yaml....and I don't know whether it should be added there...why do we need chromium-browser as a dependency? @ipa-fmw @ipa-nhg

@fmessmer

This comment has been minimized.

Copy link
Member Author

commented Apr 1, 2016

I commented the dependency to chromium-browser and released ros/rosdistro#10969

@@ -20,7 +20,7 @@
<exec_depend>language-pack-en</exec_depend>
<exec_depend>language-pack-de</exec_depend>
<exec_depend>openssh-server</exec_depend>
<exec_depend>chromium-browser</exec_depend>
<!--exec_depend>chromium-browser</exec_depend-->

This comment has been minimized.

Copy link
@floweisshardt

floweisshardt Apr 2, 2016

Member

the purpose for the desktop variant is to provide everything we use on a normal development machine. This includes a lot of thing which are not ROS or robot related, e.g. meld, tree, bride, latex, chromium.

so I vote for adding chormium to rosdistro and readd it as a dependency here.

This comment has been minimized.

Copy link
@fmessmer

fmessmer Apr 2, 2016

Author Member

What's the rosdep key for fedora then? chromium-stable?

This comment has been minimized.

Copy link
@floweisshardt

floweisshardt Apr 2, 2016

Member

no idear? can't you skip fedora in the release process? are all other cob_* packages successfully released for fedora?

This comment has been minimized.

Copy link
@fmessmer

fmessmer Apr 2, 2016

Author Member

Yes, they are. At least it seems like it.
During release, it tells me that the fedora rosdep key is not found...it also offers me to skip, but has a very thorough warning saying only to do so in case I'm absolutely sure that the key is not available in fedora...this is why I did not skip it 😉

@floweisshardt

This comment has been minimized.

Copy link
Member

commented Jul 14, 2016

I'll merge this and revert the commented chromium line afterwards

@floweisshardt floweisshardt merged commit ae7761e into indigo_dev Jul 14, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.