Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

70 contributing md #73

Merged
merged 4 commits into from Mar 16, 2016

Conversation

@francisluong
Copy link
Member

commented Mar 11, 2016

To address issue #70, add a stripped down document on contributing.

@francisluong

This comment has been minimized.

Copy link
Member Author

commented Mar 11, 2016

Can I get a volunteer for review? @mikemackintosh @gauthier-delacroix @bluemonk

Thanks!

@gdlx

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2016

Seems pretty clear. Just, why don't you add this to the readme ?
Many projects have a contribution section in the readme. Not sure I'd have the reflex to look for a contribution MD...
And what's this .idea/ ignore ? Not sure you should gitignore every personal working directory contributors could use...

@mikemackintosh

This comment has been minimized.

Copy link
Collaborator

commented Mar 14, 2016

Looks great, but I think adding this to the README directly gives better attribution than having a contributors file.

@francisluong

This comment has been minimized.

Copy link
Member Author

commented Mar 16, 2016

Main benefit is that Github does a banner for CONTRIBUTING.md:
https://github.com/blog/1184-contributing-guidelines

Lemme resolve conflicts and I will merge.

@gauthier-delacroix: .idea/ is a meta folder used by IntelliJ/Rubymine to store config state specific to that edittor/IDE. It will be common for anyone who uses it.

@francisluong

This comment has been minimized.

Copy link
Member Author

commented Mar 16, 2016

If all looks well to you guys, can one of you merge? It's tradition on the coding teams I work on that we do not merge our own PRs.
@gauthier-delacroix @mikemackintosh

@mikemackintosh

This comment has been minimized.

Copy link
Collaborator

commented Mar 16, 2016

Checking it out now

@mikemackintosh

This comment has been minimized.

Copy link
Collaborator

commented Mar 16, 2016

Nice catch on the CONTRIBUTING.md banner. Looks good. Merging.

mikemackintosh added a commit that referenced this pull request Mar 16, 2016

@mikemackintosh mikemackintosh merged commit 74e82ee into ipaddress-gem:master Mar 16, 2016

@francisluong

This comment has been minimized.

Copy link
Member Author

commented Mar 16, 2016

Sweet. Next... to get bluemonk to move this repo to an org and we can get Travis CI setup without requiring his direct involvement.

@gdlx

This comment has been minimized.

Copy link
Contributor

commented Mar 16, 2016

Main benefit is that Github does a banner for CONTRIBUTING.md:
https://github.com/blog/1184-contributing-guidelines

@gauthier-delacroix: .idea/ is a meta folder used by IntelliJ/Rubymine to store config state specific to that edittor/IDE. It will be common for anyone who uses it.

Learnt 2 things today ;o)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.