Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial Python 3.7 Support #261

Merged
merged 1 commit into from May 14, 2019

Conversation

Projects
None yet
2 participants
@lbfs
Copy link
Contributor

commented May 13, 2019

Seems to be some pickling errors when trying to pass around a multiprocessing.Process object in Python 3.7. I don't fully understand why this works in Python 3.6. This fix should be backwards compatible with Python 3.6, however I have not tested it on Windows.

This isn't a current problem, but if DeepFaceLab wants to upgrade Python versions at some point, then this would be a necessary fix.

I only consider this partial because the default Tensorflow shipped is Tensorflow 12.0, which unless using a custom build will not work with Python 3.7. However, it does work with Tensorflow 13, but then we run into the batch size regression.

Anyways, let me know what you think.

Referenced issue:
#194

@lbfs lbfs force-pushed the lbfs:py37 branch from 9a2ec38 to d04e423 May 13, 2019

@iperov iperov merged commit ba4e377 into iperov:master May 14, 2019

@lbfs lbfs deleted the lbfs:py37 branch May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.