Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity is not the same thing as equality in Python #291

Merged
merged 1 commit into from Jun 27, 2019

Conversation

Projects
None yet
2 participants
@cclauss
Copy link
Contributor

commented Jun 25, 2019

Use ==/!= to compare str, bytes, and int literals

$ python

>>> method = 'Mi'
>>> method += 'n'
>>> method == 'Min'
True
>>> method is 'Min'
False
Identity is not the same thing as equality in Python
Use ==/!= to compare str, bytes, and int literals
$ python
```python
>>> method = 'Mi'
>>> method += 'n'
>>> method == 'Min'
True
>>> method is 'Min'
False
```

@iperov iperov merged commit 93ee889 into iperov:master Jun 27, 2019

@iperov

This comment has been minimized.

Copy link
Owner

commented Jun 27, 2019

problem is MTC values tuned with this bug.

@cclauss cclauss deleted the cclauss:patch-1 branch Jun 27, 2019

darkdiable added a commit to darkdiable/DeepFaceLab that referenced this pull request Jun 29, 2019

Merge pull request #2 from iperov/master
Identity is not the same thing as equality in Python (iperov#291)

hhy5277 added a commit to hhy5277/DeepFaceLab that referenced this pull request Jul 12, 2019

Merge pull request #1 from iperov/master
Identity is not the same thing as equality in Python (iperov#291)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.